Fix(revit): Null check before attempt to override view options #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #474 +/- ##
=====================================
Coverage 9.16% 9.17%
=====================================
Files 228 228
Lines 4297 4296 -1
Branches 544 542 -2
=====================================
Hits 394 394
+ Misses 3887 3886 -1
Partials 16 16 ☔ View full report in Codecov by Sentry. |
didimitrie
approved these changes
Jan 8, 2025
oguzhankoral
deleted the
oguzhan/cnx-984-only-one-object-fails-to-convert-from-revit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I remember @didimitrie you were fixing an issue on forum while implementing
OverrideViewOptionsfunction, i believe what i did shouldn't effect what you have done before, but would be nice if you can test that behavior.BEFORE
AFTER
